Skip to content

DOCSP-44505 - v2.30 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024
Merged

DOCSP-44505 - v2.30 #255

merged 2 commits into from
Oct 16, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Oct 16, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44505

Staging Links

  • whats-new
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Oct 16, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 21dbd0c
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/67101148f7a9330008e54aa1
    😎 Deploy Preview https://deploy-preview-255--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM w/ one potential update

    @@ -37,7 +37,7 @@
    - .NET 4.7 [#2.14-note]_
    - .NET 4.6

    * - 2.13 to 2.29
    * - 2.13 to 2.30
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Do we need to update the table just above this one too? Currently it only goes to 2.29

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    good catch!

    @mongoKart mongoKart merged commit d2fdbc1 into mongodb:master Oct 16, 2024
    4 of 6 checks passed
    @mongoKart mongoKart deleted the docsp-44505-v2.30 branch October 16, 2024 19:18
    mongoKart added a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants