Skip to content

DOCSP-45005: Specify Docs to Return #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Nov 12, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45005

Staging Links

  • fundamentals/crud/read-operations/specify-documents-to-return
  • fundamentals/crud/read-operations
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Nov 12, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 5f690f3
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/673ca60ec20910000880283e
    😎 Deploy Preview https://deploy-preview-290--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mcmorisi mcmorisi marked this pull request as ready for review November 13, 2024 14:14
    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @mcmorisi mcmorisi requested review from a team and papafe and removed request for a team November 13, 2024 16:23
    When calling ``Sort()``, you must pass in the sort definition as a parameter. You can construct a sort
    definition by using the ``Builders<T>.Sort.Ascending()`` method to sort values from
    lowest to highest, or the ``Builders<T>.Sort.Ascending()`` method to sort them from highest
    to lowest. Both of these methods take the field name to sort by as a parameter.
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I'm not sure here how much "complete" we want this section to be, but I think it would be worth mentioning here that:

    1. You can also build a SortDefinition by using a BsonDocument
    2. You can chain the Builders<T>.Sort methods. For example Builders<T>.Sort.Ascending(A).Descending(B)
    3. There are other methods on the sort definition builder Builders<T>.Sort, for example Combine, that can be used to combine multiple sort definition, or other methods that can be used for very specific use cases like MetaTextScore`
      Of all those, probably number 2 is the one worth mentioning for sure. For the others... I'm not sure how much we want to say here

    @mcmorisi mcmorisi requested a review from papafe November 19, 2024 14:52
    Copy link

    @papafe papafe left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi merged commit e9347d6 into mongodb:master Nov 19, 2024
    6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-45005-specify-docs-to-return branch November 19, 2024 17:00
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    mcmorisi added a commit that referenced this pull request Nov 19, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants