DOCSP-45007: Distinct #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
approved these changes
Nov 14, 2024
mcmorisi
requested review from
a team and
rstam
and removed request for
a team
rstam
suggested changes
Nov 15, 2024
|
|
||
| { | ||
| // start-distinct | ||
| var results = collection.Distinct<string>("borough", new BsonDocument()).ToList(); |
There was a problem hiding this comment.
It is not clear to the reader what new BsonDocument() is doing here.
I had to reverse engineer what it was: a filter that matches all documents.
As alternative to new BsonDocument() might be Builders<Restaurant>.Filters.Empty
There was a problem hiding this comment.
Might also be worth showing the type safe version:
collection.Distinct(x => x.Borough, x => true)
There was a problem hiding this comment.
Made tweaks for the next version!
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
mcmorisi
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 341fcf8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45007
Staging Links
Self-Review Checklist