DOCSP-44801: Client-side projection breaking v3.0 breaking change #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
approved these changes
Nov 20, 2024
source/upgrade/v3.txt
Outdated
Comment on lines
103
to
104
| - Queries that use client-side projections will throw an ``ExpressionNotSupportedException`` | ||
| by default with v3.0. To enable client-side projections, set the |
There was a problem hiding this comment.
S: add "error"; also since this is in the v3.0 section, I don't think you need to specify that again
Suggested change
| - Queries that use client-side projections will throw an ``ExpressionNotSupportedException`` | |
| by default with v3.0. To enable client-side projections, set the | |
| - Queries that use client-side projections will throw an ``ExpressionNotSupportedException`` error | |
| by default. To enable client-side projections, set the |
source/upgrade/v3.txt
Outdated
| @@ -97,7 +97,16 @@ Version 3.0 Breaking Changes | |||
| To configure logging in your application, see the :ref:`csharp-logging` guide. | |||
|
|
|||
| - The LINQ2 provider has been removed from this version of the driver. | |||
| You must use LINQ3 for all LINQ queries. | |||
| You must use LINQ3 for all LINQ queries. This change has the following effect on the | |||
There was a problem hiding this comment.
S: since there's only one item in this nested list, it might make more sense to just combine it all into one paragraph? Or add a line break after "You must use LINQ3 for all LINQ queries" and start a new paragraph with "Queries that use client-side projections..."
mcmorisi
added a commit
that referenced
this pull request
Nov 26, 2024
(cherry picked from commit 510f9be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44801
Staging Links
Self-Review Checklist