Skip to content

DOCSP-45010: Replica Set Operations #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Nov 21, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45010

Staging Links

  • fundamentals/read-write-configuration
  • fundamentals
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Nov 21, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 9c7326c
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/6744ec7f73840200081506d7
    😎 Deploy Preview https://deploy-preview-322--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mcmorisi mcmorisi marked this pull request as ready for review November 21, 2024 21:50
    @stephmarie17 stephmarie17 self-requested a review November 21, 2024 23:09
    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice work 🎇 LGTM with a few suggestions and a URL fix.

    @mcmorisi mcmorisi requested review from a team and adelinowona and removed request for a team November 22, 2024 14:18

    .. note:: Collections and Databases are Immutable

    ``IMongoDatabase`` and ``IMongoCollection`` instances are immutable. When you

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    IMongoClient instances are also immutable as you can't modify settings after creating them. If you need to apply different settings to an IMongoClient, IMongoDatabase, or IMongoCollection, you must use one of the With* methods. These methods are designed to always return new instances with the specified settings. I recommend updating this note to reflect this information.

    @mcmorisi mcmorisi requested a review from adelinowona November 25, 2024 21:31
    Copy link

    @adelinowona adelinowona left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi merged commit 4e440bf into mongodb:master Nov 26, 2024
    6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-45010-replica-sets branch November 26, 2024 14:30
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants