-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-45010: Replica Set Operations #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎇 LGTM with a few suggestions and a URL fix.
|
||
.. note:: Collections and Databases are Immutable | ||
|
||
``IMongoDatabase`` and ``IMongoCollection`` instances are immutable. When you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMongoClient
instances are also immutable as you can't modify settings after creating them. If you need to apply different settings to an IMongoClient
, IMongoDatabase
, or IMongoCollection
, you must use one of the With*
methods. These methods are designed to always return new instances with the specified settings. I recommend updating this note to reflect this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
(cherry picked from commit 4e440bf)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45010
Staging Links
Self-Review Checklist