Skip to content

DOCSP-44706 - Type discriminator note #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2024
Merged

DOCSP-44706 - Type discriminator note #342

merged 4 commits into from
Dec 4, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Dec 2, 2024 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44706

Staging Links

  • fundamentals/serialization/polymorphic-objects
  • upgrade/v3
  • whats-new

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Dec 2, 2024 •
    edited
    Loading

    ✅ Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit b4b242b
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/674f572ae50adc0008d5143d
    😎 Deploy Preview https://deploy-preview-342--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    stephmarie17
    stephmarie17 approved these changes Dec 3, 2024
    View reviewed changes
    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with a tiny nit 🚢

    @mongoKart mongoKart requested review from rishitb-mongodb, a team and JamesKovacs and removed request for a team December 3, 2024 19:10
    rstam
    rstam approved these changes Dec 4, 2024
    View reviewed changes
    Copy link
    Collaborator

    @rstam rstam left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    See the comment about CSHARP-5356

    source/fundamentals/serialization/polymorphic-objects.txt
    or if you pass an expression containing the ``is`` operator to the
    ``Aggregate().Match()`` method, the driver throws an exception.

    .. _csharp-discriminator-hierarchical:
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This limitation will go away when https://jira.mongodb.org/browse/CSHARP-5356 is merged.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We'll publish this now and can update in 3.2 or whenever the fix is implemented.

    @mongoKart mongoKart removed the request for review from JamesKovacs December 4, 2024 21:28
    @mongoKart mongoKart merged commit ab7d99c into mongodb:master Dec 4, 2024
    6 checks passed
    @mongoKart mongoKart deleted the docsp-44706-type-discriminators branch December 4, 2024 21:52
    github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
    @mongoKart @stephmarie17 @github-actions
    DOCSP-44706 - Type discriminator note (#342)
    04d40fb 
    Co-authored-by: Stephanie <[email protected]>
(cherry picked from commit ab7d99c)
    @github-actions github-actions bot mentioned this pull request Dec 4, 2024
    Merged
    mongoKart pushed a commit that referenced this pull request Dec 4, 2024
    @github-actions @stephmarie17
    DOCSP-44706 - Type discriminator note (#342) (#346)
    15a5b0d 
    Co-authored-by: Stephanie <[email protected]>
(cherry picked from commit ab7d99c)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rstam rstam rstam approved these changes

    @stephmarie17 stephmarie17 stephmarie17 approved these changes

    @rishitb-mongodb rishitb-mongodb rishitb-mongodb approved these changes

    Assignees
    No one assigned
    Labels
    backport v3.0
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @mongoKart @rstam @stephmarie17 @rishitb-mongodb