DOCSP-45715: Sealed class v3.0 changes #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
approved these changes
Dec 3, 2024
source/upgrade/v3.txt
Outdated
Comment on lines
208
to
212
| ``IBsonSerializer`` interface. | ||
|
|
||
| - The ``MongoClient``, ``MongoDatabase``, and ``MongoCollection`` classes have been | ||
| sealed. We recommend using the ``IMongoClient``, ``IMongoDatabase``, and |
There was a problem hiding this comment.
S: I'd update to active voice
Suggested change
| - All concrete serializers have been sealed. To implement a custom serializer, implement the | |
| ``IBsonSerializer`` interface. | |
| - The ``MongoClient``, ``MongoDatabase``, and ``MongoCollection`` classes have been | |
| sealed. We recommend using the ``IMongoClient``, ``IMongoDatabase``, and | |
| - The driver seals all concrete serializers. To implement a custom serializer, implement the | |
| ``IBsonSerializer`` interface. | |
| - The driver seals the ``MongoClient``, ``MongoDatabase``, and ``MongoCollection`` classes. We recommend using the ``IMongoClient``, ``IMongoDatabase``, and |
BorisDog
requested changes
Dec 4, 2024
| @@ -84,7 +84,7 @@ The following code example shows a custom ``BsonRegularExpression`` serializer: | |||
|
|
|||
| .. code-block:: csharp | |||
|
|
|||
| class CustomRegularExpressionSerializer : SerializerBase<Regex> | |||
| class CustomRegularExpressionSerializer : IBsonSerializer<Regex> | |||
There was a problem hiding this comment.
This doesn't compile, so need to adapt the CustomRegularExpressionSerializer accordingly.
source/upgrade/v3.txt
Outdated
| cluster events, use `ClusterBuilder.Subscribe() <{+new-api-root+}/MongoDB.Driver/MongoDB.Driver.Core.Configuration.ClusterBuilder.Subscribe.html>`__. | ||
|
|
||
| - The driver seals all concrete serializers. To implement a custom serializer, implement the |
There was a problem hiding this comment.
We had some questions of "why" classes got sealed.
It's worth adding a general comment followed by these concrete examples:
Something like "Some of the types that were not designed for extension via inheritance became sealed. Starting with 3.0 we recommend using "composition over inheritance" approach for extending the driver functionality."
mcmorisi
added a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit a927257)
mcmorisi
added a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit a927257)
mongoKart
pushed a commit
to mongoKart/docs-csharp
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45715 and https://jira.mongodb.org/browse/DOCSP-45716
Staging Links
Self-Review Checklist