-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-49230 - Aggregation stages (builders) #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docsp-45382-comp-cvg
Are you sure you want to change the base?
DOCSP-49230 - Aggregation stages (builders) #591
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
source/aggregation/stages.txt
Outdated
* - :manual:`$bucket </reference/operator/aggregation/bucket/>` | ||
- Categorizes incoming documents into groups, called buckets, | ||
based on a specified expression and bucket boundaries. | ||
- :ref:`Bucket() <csharp-aggregation-bucket>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All method links are broken pending future PRs
source/aggregation/stages.txt
Outdated
- Builders Method | ||
|
||
* - :manual:`$bucket </reference/operator/aggregation/bucket/>` | ||
- Categorizes incoming documents into groups, called buckets, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stage descriptions were taken (almost) verbatim from server docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work!
source/aggregation.txt
Outdated
:titlesonly: | ||
:maxdepth: 1 | ||
|
||
Stages </aggregation/stages> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: consider titling this Pipeline Stages
source/aggregation/stages.txt
Outdated
.. _csharp-aggregation-stages: | ||
|
||
================== | ||
Aggregation Stages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: consider calling this pipeline stages or aggregation pipeline stages
source/aggregation/stages.txt
Outdated
On this page, you can learn how to create an aggregation pipeline and add stages to it | ||
by using methods in the {+driver-short+}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: since this guide is more about creating the stages than adding them to a pipeline
On this page, you can learn how to create an aggregation pipeline and add stages to it | |
by using methods in the {+driver-short+}. | |
On this page, you can learn how to create an aggregation pipeline and pipeline stages | |
by using methods in the {+driver-short+}. |
source/aggregation/stages.txt
Outdated
in the aggregation pipeline, but doesn't provide type hints or type safety. | ||
|
||
The following code example shows how to add ``$unset``, an aggregation | ||
stage without a corresponding method, to an empty aggregation pipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stage without a corresponding method, to an empty aggregation pipeline: | |
stage without a corresponding builder method, to an empty aggregation pipeline: |
source/aggregation/stages.txt
Outdated
Aggregation Stage Methods | ||
------------------------- | ||
|
||
The following table lists the builders methods in the {+driver-short+} that correspond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following table lists the builders methods in the {+driver-short+} that correspond | |
The following table lists the builder methods in the {+driver-short+} that correspond |
source/aggregation/stages.txt
Outdated
to stages in the aggregation pipeline. For more information about an aggregation stage, | ||
click the stage name. For more information about a builders method, click the | ||
method name. If an aggregation stage isn't in the table, you must use the | ||
:ref:`BsonDocument <csharp-aggregation-stages-bsondocument>` syntax to add the stage | ||
to your pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to stages in the aggregation pipeline. For more information about an aggregation stage, | |
click the stage name. For more information about a builders method, click the | |
method name. If an aggregation stage isn't in the table, you must use the | |
:ref:`BsonDocument <csharp-aggregation-stages-bsondocument>` syntax to add the stage | |
to your pipeline. | |
to stages in the aggregation pipeline. To learn more about an aggregation stage, | |
follow the link from the stage name to the Server manual reference. To learn more about a | |
builder method, follow the link from the method name to the dedicated guide. If an | |
aggregation stage isn't in the table, the driver does not provide a builder method, so you must use the | |
:ref:`BsonDocument <csharp-aggregation-stages-bsondocument>` syntax to add the stage | |
to your pipeline. |
source/aggregation/stages.txt
Outdated
- Performs a recursive search on a collection. To each output | ||
document, adds a new array field that contains the traversal | ||
results of the recursive search for that document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Performs a recursive search on a collection. To each output | |
document, adds a new array field that contains the traversal | |
results of the recursive search for that document. | |
- Performs a recursive search on a collection. This method adds | |
a new array field to each output document that contains the traversal | |
results of the recursive search for that document. |
source/aggregation/stages.txt
Outdated
----------------- | ||
|
||
To learn more about assembling an aggregation pipeline, see | ||
:manual:`Aggregation Pipeline </core/aggregation-pipeline/>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: add link target
:manual:`Aggregation Pipeline </core/aggregation-pipeline/>`. | |
:manual:`Aggregation Pipeline </core/aggregation-pipeline/>` in the Server manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applies everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont need to take another look unless you request. Nice job!
source/aggregation/stages.txt
Outdated
The following code example shows how to add ``$unset``, an aggregation | ||
stage without a corresponding builder method, to an empty aggregation pipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S; wording still awkward, maybe try this wording as its actually not super important to know that the stage doesnt have a builder method (since you can do this with any stage)
The following code example shows how to add ``$unset``, an aggregation | |
stage without a corresponding builder method, to an empty aggregation pipeline: | |
The following code example shows how to add an ``$unset`` stage to an empty aggregation pipeline: |
source/aggregation/stages.txt
Outdated
.. code-block:: csharp | ||
|
||
var pipeline = new EmptyPipelineDefinition<BsonDocument>() | ||
.AppendStage<BsonDocument, BsonDocument, BsonDocument>("{ $unset: "field1" }"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: text highlighting weird, do you need to escape the characters as there's multiple sets of " marks?
source/aggregation/stages.txt
Outdated
available for self-managed deployments. To learn more, see | ||
:atlas:`Atlas Search Aggregation Pipeline Stages | ||
</reference/atlas-search/query-syntax>` in the Atlas documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: change the link to go to the atlas vector search overview
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49230
Staging Links
Self-Review Checklist