Skip to content

DOCSP-49085: Port existing Vector Search page #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: docsp-45382-comp-cvg
Choose a base branch
from

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jun 2, 2025

Pull Request Info

READ BEFORE REVIEW

Rea created a Vector Search page since we started the CC branch. The majority of this PR is pulling her page in with a few extras, namely:

  • The Sample Data section is new
  • The Linq and Builders sections + snippets are new
  • Few extra API links

Everything else was previously reviewed

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49085

Staging Links

  • atlas-vector-search
  • indexes
  • serialization
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Jun 2, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit ac4efac
    🔍 Latest deploy log https://app.netlify.com/projects/docs-csharp/deploys/68405ace8339fc0008fa1628
    😎 Deploy Preview https://deploy-preview-643--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice work! A few questions and comments.

    guide, see the following API Documentation:

    - `BinaryVectorFloat32 <{+new-api-root+}/MongoDB.Bson/MongoDB.Bson.BinaryVectorFloat32.html>`__
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    [i] A few of these links were a 404:

    • BinaryVectorFloat32
    • BinaryVectorInt8
    • BinaryVectorPackedBit
    • ToQueryVector

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    So production is using C# version 3.4 and these links work – this is an issue specific to the comp cvg branch.

    @mcmorisi mcmorisi requested a review from stephmarie17 June 3, 2025 14:35
    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with a few fixes but don't think those require a re-review 🚢

    @mcmorisi mcmorisi requested review from a team and sanych-sun and removed request for a team June 3, 2025 17:57
    @BorisDog BorisDog requested review from damieng and removed request for sanych-sun June 6, 2025 22:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants