-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Dockerfile compatible with PHPUnit 9 #2186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2186 +/- ##
=========================================
Coverage 86.99% 86.99%
Complexity 664 664
=========================================
Files 33 33
Lines 1561 1561
=========================================
Hits 1358 1358
Misses 203 203 Continue to review full report at Codecov.
|
ARG is param can be passed through |
Oh, thanks!! I really forgot about |
Docker file already doesn't run correctly tests. Bumping two variables doesn't change anything. Thanks! |
Well, ok, but I could run standalone test correctly on master with this bump. So others might run this kind of tests too. |
Docker file doesn't contain any code to run tests. Could you please show me where exactly it does otherwise? Thanks! |
What was I meaning that when you start it with docker-compose the PHP container should run tests automatically. There is no point in running it manually each time. @Smolevich what do you think? Thanks! |
Co-authored-by: Divine <[email protected]>
Thank you for your contribution! Much appreciated! |
Make Dockerfile compatible with PHPUnit 9
PHPUnit 9 only runs with PHP >=7.3, also updated to Composer 2