Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dockerfile compatible with PHPUnit 9 #2186

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

stephandesouza
Copy link
Contributor

PHPUnit 9 only runs with PHP >=7.3, also updated to Composer 2

@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #2186 (c9eba55) into master (ae864fb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2186   +/-   ##
=========================================
  Coverage     86.99%   86.99%           
  Complexity      664      664           
=========================================
  Files            33       33           
  Lines          1561     1561           
=========================================
  Hits           1358     1358           
  Misses          203      203           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae864fb...c9eba55. Read the comment docs.

@Smolevich
Copy link
Contributor

ARG is param can be passed through docker build --build-arg PHP_VERSION=8.0 ... I think that changing default params is can be realized later, after big refactoring code base

@Smolevich Smolevich requested review from jenssegers and Smolevich and removed request for jenssegers January 15, 2021 13:15
@stephandesouza
Copy link
Contributor Author

Oh, thanks!! I really forgot about build-args on Docker.

@divine
Copy link
Contributor

divine commented Jan 16, 2021

Docker file already doesn't run correctly tests. Bumping two variables doesn't change anything.

Thanks!

@divine divine closed this Jan 16, 2021
@stephandesouza
Copy link
Contributor Author

Well, ok, but I could run standalone test correctly on master with this bump.

So others might run this kind of tests too.

@divine
Copy link
Contributor

divine commented Jan 16, 2021

Well, ok, but I could run standalone test correctly on master with this bump.

So others might run this kind of tests too.

Docker file doesn't contain any code to run tests. Could you please show me where exactly it does otherwise?

Thanks!

@stephandesouza
Copy link
Contributor Author

Sure, with docker-compose it runs smoothly: docker-compose run tests ./vendor/bin/phpunit
image

@divine
Copy link
Contributor

divine commented Jan 18, 2021

Sure, with docker-compose it runs smoothly: docker-compose run tests ./vendor/bin/phpunit
image

What was I meaning that when you start it with docker-compose the PHP container should run tests automatically.

There is no point in running it manually each time. @Smolevich what do you think?

Thanks!

@divine divine reopened this Jan 18, 2021
Co-authored-by: Divine <[email protected]>
@divine divine merged commit fe896a1 into mongodb:master Feb 2, 2021
@divine
Copy link
Contributor

divine commented Feb 2, 2021

Thank you for your contribution! Much appreciated!

mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Make Dockerfile compatible with PHPUnit 9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants