Fix Model::unset with dot field name#2582
Merged
GromNaN merged 1 commit intomongodb:masterfrom Aug 29, 2023
Merged
Conversation
GromNaN
commented
Aug 28, 2023
| $this->unset[$offset] = true; | ||
| if (str_contains($offset, '.')) { | ||
| // Update the field in the subdocument | ||
| Arr::forget($this->attributes, $offset); |
Member
Author
There was a problem hiding this comment.
This will ignore if the field is not an array.
alcaeus
previously approved these changes
Aug 28, 2023
Member
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
Change LGTM. Is this also expected to work for lists?
Member
Author
|
Currently it's half working because the value is not unset from the memory, but it's correctly removed from the database by the I'll add tests on resetting the value after unsetting. |
alcaeus
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing #2578 I did not test subfields.
Related to #1506