MONGOCRYPT-760 Rename set_error to kms_set_error
#923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set_error is an awful generic name for a global function. Sadly this easily conflicts with other libraries if you statically link this into an application. please have us rename set_error to kms_set_error to avoid link errors with libraries/applications that also have set_error as function.
also renamed set_error here
kevinAlbs
changed the title
set_error to kms_set_error
kevinAlbs
approved these changes
Dec 16, 2024
Contributor
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Thank you for the improvement. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_error is an awful generic name for a global function.
Sadly this easily conflicts with other libraries if you statically link this into an application.
please have us rename set_error to kms_set_error to avoid link errors with libraries/applications that also have set_error as function.