MONGOCRYPT-731 re-enable ASan tasks

[kevinAlbs]

Summary

• Fix Evergreen config to apply -fsanitize=address.
• Suppress dlerror leak. Fix test leaks.
• Restore default of ENABLE_EXTRA_ALIGNMENT=OFF to imported libbson.

Verified by this patch build.

As a drive-by fix, the unused build-and-test-asan-s390x is removed.

Background

#622 accidentally disabled ASan due to a bash comment (# Add ...) appearing in a folded (>-) YAML block:

compile_env: >-
    ${compile_env|}
    LIBMONGOCRYPT_EXTRA_CFLAGS="-fsanitize=address -pthread"
    # Add detect_odr_violation=0 to ASAN_OPTIONS to ignore odr-violation in IntelDFP symbol: __dpml_bid_globals_table
    ASAN_OPTIONS="detect_leaks=1 detect_odr_violation=0"

This PR moves the comment outside of the block to fix:

# Add detect_odr_violation=0 to ASAN_OPTIONS to ignore odr-violation in IntelDFP symbol: __dpml_bid_globals_table
compile_env: >-
    ${compile_env|}
    LIBMONGOCRYPT_EXTRA_CFLAGS="-fsanitize=address -pthread"
    ASAN_OPTIONS="detect_leaks=1 detect_odr_violation=0"

Re-enabling ASan revealed an Indirect leak reported in dlerror only on Ubuntu 22.04 arm64. The leak is now suppressed. I expect it is not an issue in libmongocrypt.

Re-enabling ASan revealed a variety of errors: stack-use-after-scope, stack-buffer-overflow, and a stack-use-after-scope. All were fixed by restoring a default of ENABLE_EXTRA_ALIGNMENT=OFF when importing libbson. Prints were added to pkgconfig-tests.sh and linker-tests.sh to help identify a failing tests.

Restoring ENABLE_EXTRA_ALIGNMENT=OFF default

#875 accidentally changed the default applied ENABLE_EXTRA_ALIGNMENT from false (via empty string) to true (via libbson default).

Restoring the default of ENABLE_EXTRA_ALIGNMENT=OFF triggered a crash in pkgconfig-tests.sh only on RHEL 8.1 ppc64el. The crash occurred in the libmongocrypt dynamic linking against libbson cases. I expect this is caused by libmongocrypt building against the imported libbson with extra alignment disabled. Then using the installed shared libbson with extra alignment enabled. I am not sure why this crash did not occur before #875. A patch build on the commit before #875 passes, but crashes after upgrading to libbson from 1.27.1 to 1.28.1 (current version used by libmongocrypt). I expect the test previously passed "by accident". The test is updated to ensure matching alignment.

[eramongodb]

Minor suggestions; otherwise, LGTM.

[eramongodb]

Do we have more information about the "installed libbson" library? Can it be updated so it is also configured with ENABLE_EXTRA_ALIGNMENT=OFF?

[kevinAlbs]

Yes the "installed libbson" is installed within this script. Updated the "installed libbson" to set ENABLE_EXTRA_ALIGNMENT=OFF to match recommended libbson default.

[rcsanchez97]

LGTM