Skip to content

CSHARP-5370: Test driver-generated '_id' fields are first in documents #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CSHARP-5370: Test driver-generated '_id' fields are first in documents #1667

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1af1bf
CSHARP-5370: Test driver-generated '_id' fields are first in documents
adelinowona Apr 8, 2025
22b9e5d
address pr comments
adelinowona Apr 11, 2025
8c79d18
fix EG failures
adelinowona Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions tests/MongoDB.Driver.Tests/Specifications/crud/prose-tests/CrudProseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,81 @@ public async Task MongoClient_bulkWrite_unacknowledged_write_concern_uses_w0_all
documentCount.Should().Be(numModels);
}

// https://specifications.readthedocs.io/en/latest/crud/tests/#16-generated-document-identifiers-are-the-first-field-in-their-document
// The next three consecutive tests defined below are part of the prose test linked above.
[Theory]
[ParameterAttributeData]
public async Task Ensure_generated_ids_are_first_fields_in_document_using_insertOne([Values(true, false)] bool async)
{
var eventCapturer = new EventCapturer().Capture<CommandStartedEvent>();
var client = CreateMongoClient(eventCapturer);
var testCollection = client.GetDatabase("test").GetCollection<BsonDocument>("test");

var document = new BsonDocument("x", 1);
if (async)
{
await testCollection.InsertOneAsync(document);
}
else
{
testCollection.InsertOne(document);
}

var insertEvents = eventCapturer.Events.OfType<CommandStartedEvent>().Where(e => e.CommandName == "insert").ToArray();
insertEvents.Length.Should().Be(1);
insertEvents[0].Command["documents"][0].AsBsonDocument.Names.First().Should().Be("_id");
document.Names.Should().Contain("_id");
}

[Theory]
[ParameterAttributeData]
public async Task Ensure_generated_ids_are_first_fields_in_document_using_collection_bulkWrite([Values(true, false)] bool async)
{
var eventCapturer = new EventCapturer().Capture<CommandStartedEvent>();
var client = CreateMongoClient(eventCapturer);
var testCollection = client.GetDatabase("test").GetCollection<BsonDocument>("test");

var document = new BsonDocument("x", 1);
if (async)
{
await testCollection.BulkWriteAsync([new InsertOneModel<BsonDocument>(document)]);
}
else
{
testCollection.BulkWrite([new InsertOneModel<BsonDocument>(document)]);
}

var insertEvents = eventCapturer.Events.OfType<CommandStartedEvent>().Where(e => e.CommandName == "insert").ToArray();
insertEvents.Length.Should().Be(1);
insertEvents[0].Command["documents"][0].AsBsonDocument.Names.First().Should().Be("_id");
document.Names.Should().Contain("_id");
}

[Theory]
[ParameterAttributeData]
public async Task Ensure_generated_ids_are_first_fields_in_document_using_client_bulkWrite([Values(true, false)] bool async)
{
RequireServer.Check().Supports(Feature.ClientBulkWrite).Serverless(false);

var eventCapturer = new EventCapturer().Capture<CommandStartedEvent>();
var client = CreateMongoClient(eventCapturer);

var document = new BsonDocument("x", 1);
if (async)
{
await client.BulkWriteAsync([new BulkWriteInsertOneModel<BsonDocument>("test.test", document)]);
}
else
{
client.BulkWrite([new BulkWriteInsertOneModel<BsonDocument>("test.test", document)]);
}

var bulkEvents = eventCapturer.Events.OfType<CommandStartedEvent>().Where(e => e.CommandName == "bulkWrite").ToArray();
bulkEvents.Length.Should().Be(1);
bulkEvents[0].Command["ops"][0]["document"].AsBsonDocument.Names.First().Should().Be("_id");
document.Names.Should().Contain("_id");
}

// private methods
private FailPoint ConfigureFailPoint(string failpointCommand)
{
Expand Down