Skip to content

CSHARP-5880: Fix flaky RetryableReadsProseTests.PoolClearedError_read_retryablity_test #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanych-sun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CSHARP-5880: Fix flaky RetryableReadsProseTests.PoolClearedError_read_retryablity_test #1876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MongoDB.Driver/Core/Misc/Feature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public class Feature
private static readonly Feature __directConnectionSetting = new Feature("DirectConnectionSetting", WireVersion.Server44);
private static readonly Feature __electionIdPriorityInSDAM = new Feature("ElectionIdPriorityInSDAM ", WireVersion.Server60);
private static readonly Feature __eval = new Feature("Eval", WireVersion.Zero, WireVersion.Server42);
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change intentionally diverges from the documented introduction of failPoint blockTimeMS in 4.2.x by gating the feature at 4.4. Please add a short comment (or a reference to the related ticket/server behavior) explaining why 4.2 is excluded, so future readers don’t “fix” this back to Server42 and reintroduce flakiness.

Suggested change
private static readonly Feature __eval = new Feature("Eval", WireVersion.Zero, WireVersion.Server42);
private static readonly Feature __eval = new Feature("Eval", WireVersion.Zero, WireVersion.Server42);
// Note: although the server documentation lists failPoint blockTimeMS as available in 4.2.x,
// the 4.2 implementation caused test flakiness. We intentionally require 4.4+ here.

Copilot uses AI. Check for mistakes.
private static readonly Feature __failPointsBlockConnection = new Feature("FailPointsBlockConnection", WireVersion.Server42);
private static readonly Feature __failPointsBlockConnection = new Feature("FailPointsBlockConnection", WireVersion.Server44);
private static readonly Feature __failPointsFailCommand = new Feature("FailPointsFailCommand", WireVersion.Server40);
private static readonly Feature __failPointsFailCommandForSharded = new Feature("FailPointsFailCommandForSharded", WireVersion.Server42);
private static readonly Feature __filterLimit = new Feature("FilterLimit", WireVersion.Server60);
Expand Down