CSHARP-5863: The built-in IPAddressSerializer throws when using IPAddress.Any, etc
#1880
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Address.Any`, etc.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds coverage and a serializer tweak to ensure IPAddressSerializer can handle special/built-in IPAddress instances (e.g., IPAddress.Any, Broadcast, IPv6 special values) without throwing.
Changes:
- Added theory test cases covering special
IPAddressvalues for JSON (Shell mode) and BSON roundtrips. - Overrode
IPAddressSerializer.Serializeto force nominal-type serialization (SerializeAsNominalType = true) before delegating to the base implementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/MongoDB.Bson.Tests/Serialization/Serializers/NetPrimitiveSerializerTests.cs | Adds theory + member data to validate special IPAddress values serialize/roundtrip correctly. |
| src/MongoDB.Bson/Serialization/Serializers/IPAddressSerializer.cs | Forces nominal-type serialization to avoid failures when serializing special/built-in IPAddress instances. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/MongoDB.Bson.Tests/Serialization/Serializers/NetPrimitiveSerializerTests.cs
Outdated
Show resolved
Hide resolved
sanych-sun
added
bug
sanych-sun
changed the title
IPAddressSerializer throws when using IPAddress.Any, etc.IPAddressSerializer throws when using IPAddress.Any, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.