-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ObjectID sort and serdes #1582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…va-driver into edarke/JAVA-5388
…va-driver into edarke/JAVA-5388
vbabanin
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for the improvement @Edarke! I just have a few minor comments
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
vbabanin
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: JAVA-5388
Change in-memory representation of
ObjectId
to minimize number of comparisons for sorting.This representation also has a side effect of improving methods relating to serialization/deserialization and saving 2 bytes/object. The behavior of this class should remain unchanged except for trivial differences in
hashCode()
Below are results of some JMH benchmarks measured by throughput