Add option to allow disabling the MongoClient cache. #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a server environment where the mongo-jdbc driver is used to connect to a variable number of customer databases at varying frequencies, it is not desirable to keep the MongoClients alive/open across JDBC connections, especially since every MongoClient comes with a background server monitoring thread.
Collaborator
|
Hi Roman, We have an item in our backlog already for addressing this. |
Collaborator
|
We did a different version of this that has been merged and released in 2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a server environment where the mongo-jdbc driver is used to connect to a variable number of customer databases to run queries at varying frequencies, it is not desirable to keep the MongoClients alive/open across JDBC connections, especially since every MongoClient comes with a background server monitoring thread.
This PR adds an option to disable the mongo client cache, so that the client is owned by the JDBC connection and closed together with it, as was the case before the cache was introduced in #260.