-
Notifications
You must be signed in to change notification settings - Fork 191
RUST-452 Fix tests with async-std 1.6.x #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d528cdb to
843ddfa
Compare
patrickfreed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we're seeing some timeouts where the tests run for over 60 seconds. They don't look related to open file counts being hit, though. Does 1.6 a really serious performance regression?
9f693bf to
34fd2a6
Compare
| let uri = std::env::var("MONGODB_URI") | ||
| .unwrap_or_else(|_| "mongodb://localhost:27017".to_string()); | ||
| let mut options = RUNTIME.block_on(ClientOptions::parse(&uri)).unwrap(); | ||
| let mut options = ClientOptions::parse_without_srv_resolution(&uri).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
|
|
||
| [dependencies.async-std] | ||
| version = "~1.5.0" | ||
| version = "1.6.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@patrickfreed We had some performance issues with the 1.6.x releases, as that was when we switched to a |
|
I've run an example with edit: fixed the issues in the session store; everything seems fine ✨ |
|
@yoshuawuyts we plan to do a beta release of the driver tomorrow, so this change will be available to users then! |
|
@saghm yay, exciting! |
No description provided.