Skip to content

Conversation

@saghm
Copy link
Contributor

@saghm saghm commented May 26, 2020

No description provided.

@saghm saghm force-pushed the RUST-452 branch 3 times, most recently from d528cdb to 843ddfa Compare May 27, 2020 20:40
@saghm saghm marked this pull request as ready for review May 27, 2020 23:42
Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're seeing some timeouts where the tests run for over 60 seconds. They don't look related to open file counts being hit, though. Does 1.6 a really serious performance regression?

@saghm saghm force-pushed the RUST-452 branch 3 times, most recently from 9f693bf to 34fd2a6 Compare May 29, 2020 20:48
@saghm saghm marked this pull request as draft June 8, 2020 19:50
let uri = std::env::var("MONGODB_URI")
.unwrap_or_else(|_| "mongodb://localhost:27017".to_string());
let mut options = RUNTIME.block_on(ClientOptions::parse(&uri)).unwrap();
let mut options = ClientOptions::parse_without_srv_resolution(&uri).unwrap();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!


[dependencies.async-std]
version = "~1.5.0"
version = "1.6.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@yoshuawuyts
Copy link

Does 1.6 a really serious performance regression?

@patrickfreed We had some performance issues with the 1.6.x releases, as that was when we switched to a smol-based core. Those issues have since been resolved, and performance should be reliable.

@yoshuawuyts
Copy link

yoshuawuyts commented Jul 28, 2020

I've run an example with async-mongodb-session and haven't experienced any timeouts or hangs so far. We did find another bug in our impl of the session store (http-rs/async-mongodb-session#3), but that's most likely because of logic on our side than something caused by the mongo driver.

edit: fixed the issues in the session store; everything seems fine ✨

@saghm saghm marked this pull request as ready for review July 28, 2020 20:17
@saghm saghm changed the title RUST-452 Fix tests with async-std 1.6.0 RUST-452 Fix tests with async-std 1.6.x Jul 29, 2020
@saghm saghm merged commit 3d0ec19 into mongodb:master Jul 29, 2020
@saghm saghm deleted the RUST-452 branch July 29, 2020 17:21
@saghm
Copy link
Contributor Author

saghm commented Jul 29, 2020

@yoshuawuyts we plan to do a beta release of the driver tomorrow, so this change will be available to users then!

@yoshuawuyts
Copy link

@saghm yay, exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants