MONGOID-5852 Fix after_action_commit callbacks#5968
Merged
jamis merged 1 commit intomongodb:masterfrom Mar 21, 2025
Merged
Conversation
None of them worked due to a syntax error where `set_options_for_callbacks` did not accept a second argument.
Contributor
Author
|
The change to |
comandeo-mongo
changed the title
comandeo-mongo
approved these changes
Mar 21, 2025
jamis
approved these changes
Mar 21, 2025
Contributor
jamis
left a comment
jamis
left a comment
There was a problem hiding this comment.
Good catch! Thanks for the PR. 👍
comandeo-mongo
pushed a commit
to comandeo-mongo/mongoid
that referenced
this pull request
Mar 21, 2025
None of them worked due to a syntax error where `set_options_for_callbacks` did not accept a second argument.
Closed
comandeo-mongo
added a commit
that referenced
this pull request
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of them worked due to a syntax error where
set_options_for_callbacksdid not accept a second argument.I thought this fix was relatively straightforward enough to be a quick PR without going through support. Apologies if I did something incorrectly, I'm new to Mongo in general.