Skip to content

Conversation

@PavelSafronov
Copy link
Contributor

Description

Summary of Changes

This PR syncs CSOT spec tests to latest and skips any tests that are currently failing.
3 of the new tests are failing, so they are being skipped in this PR, and will be addressed in issue NODE-7297

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@PavelSafronov PavelSafronov marked this pull request as ready for review November 13, 2025 23:02
@PavelSafronov PavelSafronov requested a review from a team as a code owner November 13, 2025 23:02
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For spec test syncs, we try to ensure that the files match the spec repo exactly, so we don't modify any fields. Instead, we do skips inside the spec.test.ts files that actually pull in the spec tests to be executed. Take a look at the client_side_operations_timeout.spec.test.ts, there are already some CSOT tests being skipped there.

@dariakp dariakp self-assigned this Nov 14, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 14, 2025
@PavelSafronov
Copy link
Contributor Author

For spec test syncs, we try to ensure that the files match the spec repo exactly, so we don't modify any fields. Instead, we do skips inside the spec.test.ts files that actually pull in the spec tests to be executed. Take a look at the client_side_operations_timeout.spec.test.ts, there are already some CSOT tests being skipped there.

Makes perfect sense. Reverting manual changes, adding the skipped tests to the common location.

@dariakp dariakp merged commit 287c98a into mongodb:main Nov 14, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants