Skip to content

doc: Adds basic module for mongodbatlas_advanced_cluster (Preview for MongoDB Atlas Provider 2.0.0)#3270

Merged
EspenAlbert merged 9 commits intomasterfrom
CLOUDP-304982_cluster_migration_v4_module
Apr 15, 2025
Merged

doc: Adds basic module for mongodbatlas_advanced_cluster (Preview for MongoDB Atlas Provider 2.0.0)#3270
EspenAlbert merged 9 commits intomasterfrom
CLOUDP-304982_cluster_migration_v4_module

Conversation

@EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented Apr 11, 2025

Description

  • Adds v4 module for mongodbatlas_advanced_cluster (Preview for MongoDB Atlas Provider 2.0.0)
    • Represents a major upgrade, removing all compatibility with old cluster resource

Link to any related issue(s): CLOUDP-304982

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert marked this pull request as ready for review April 14, 2025 07:54
@EspenAlbert EspenAlbert requested review from a team as code owners April 14, 2025 07:54
@github-actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

4. Update the references from your previous cluster resource: `mongodbatlas_cluster.this.XXXX` to the new `mongodbatlas_advanced_cluster.this.XXX`.
- Double check [output-changes](#output-changes) to ensure the underlying configuration stays unchanged.
- If you are using output variables that use the new resource `mongodbatlas_advanced_cluster.this`, the plan output can be more verbose than expected (extra `Note: Objects have changed outside of Terraform` section). Consider adding/updating output variables only **after** performing the move (see more in the [Github Issue](https://github.com/hashicorp/terraform-plugin-framework/issues/1109)).
- If you are using output variables that use the new resource `mongodbatlas_advanced_cluster.this`, the plan output can be more verbose than expected (extra `Note: Objects have changed outside of Terraform` section). Consider adding/updating output variables only **after** performing the move (see more in the [Github Issue](https://github.com/hashicorp/terraform/issues/36796).
Copy link
Member

@lantoli lantoli Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if the HC issue can be very technical for most users and might confuse them, consider removing the link to it. same comment for the other occurences

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think part of the value in the link is to make the user aware of the source of the plan output problem.
Although they don't understand the issue detail, they can understand it is not only on us.

Copy link
Contributor

@jvincent-mongodb jvincent-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits.

Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EspenAlbert EspenAlbert merged commit 661da59 into master Apr 15, 2025
40 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-304982_cluster_migration_v4_module branch April 15, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants