Skip to content

chore: Removes all usages of MONGODB_ATLAS_ENABLE_PREVIEW #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

chore: Removes all usages of MONGODB_ATLAS_ENABLE_PREVIEW #3285

merged 3 commits into from
Apr 16, 2025

Conversation

AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Apr 16, 2025 •
edited
Loading

Description

Link to any related issue(s): CLOUDP-282801

MONGODB_ATLAS_ENABLE_PREVIEW is no longer used after the GA of resource policies (#3276).
Moving forwards preview features will be enabled with feature specific flags, as done with MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

AgustinBettati
AgustinBettati commented Apr 16, 2025
View reviewed changes
internal/service/resourcepolicy/resource_migration_test.go
Comment on lines -10 to -17
mig.SkipIfVersionBelow(t, "1.22.0") // this feature was introduced in provider version 1.21.0, plural data source schema was changed in 1.22.0

var description *string
if mig.IsProviderVersionAtLeast("1.32.0") {
description = descriptionPtr
}

mig.CreateAndRunTestNonParallel(t, basicTestCase(t, description))
Copy link
Member Author

@AgustinBettati AgustinBettati Apr 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a test failure in our CI that was detected today (reference failure, #3276 which caused failure).
Older versions require the env variable to be defined, since this PR completely remove the usages of legacy env variable this test would start running again after 1.33.0 release. Don't see significant concern as this test has been passing up until today, and will start running again as soon as we do our next release.

@AgustinBettati AgustinBettati marked this pull request as ready for review April 16, 2025 09:19
@AgustinBettati AgustinBettati requested a review from a team as a code owner April 16, 2025 09:19
EspenAlbert
EspenAlbert approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lantoli
lantoli reviewed Apr 16, 2025
View reviewed changes
README.md
@@ -27,13 +27,6 @@ To use a released provider in your Terraform environment, run [`terraform init`]

Documentation about the provider specific configuration options can be found on the [provider's website](https://www.terraform.io/docs/providers/).

## Preview Features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to keep some generic Preview features doc, like each feature will have their own env.var?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had the same thought. Since we don't have a general purpose env var think it is okay to just call out in each specific resource as we currently do for advanced_cluster tfp (reference).

@AgustinBettati AgustinBettati merged commit 560c2e8 into master Apr 16, 2025
44 checks passed
@AgustinBettati AgustinBettati deleted the CLOUDP-282801 branch April 16, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli lantoli approved these changes

@EspenAlbert EspenAlbert EspenAlbert approved these changes

@oarbusi oarbusi oarbusi approved these changes

@maastha maastha maastha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AgustinBettati @lantoli @EspenAlbert @oarbusi @maastha