Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(quotes): add English quotes from Brandon Sanderson's works (@TimMayr) #6241

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

TimMayr
Copy link

@TimMayr TimMayr commented Feb 7, 2025

Description

Added around 250 English quotes related to Brandon Sanderson's works

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Feb 7, 2025
@TimMayr TimMayr changed the title impr(quotes): add English quotes from Brandon Sanderson's Cosmere (@TimMayr) impr(quotes): add English quotes from Brandon Sanderson's works (@TimMayr) Feb 7, 2025
@AnnaBuchholz
Copy link
Contributor

AnnaBuchholz commented Feb 10, 2025

FYI I believe the second book in the Mistborn Series is spelled the "Well of Ascension", not "Well of Ascention". I know it's small and I'm not trying to nitpick you too much but I just so happened to notice it so I figured I'd let you know. Thanks for spending the time to add the quotes though!

@TimMayr
Copy link
Author

TimMayr commented Feb 10, 2025

@AnnaBuchholz Oh yeah you're totally right. English isn't my native language, and Ascension was always a hard word for me, so I kinda just hit keys until the spellchecker went silent.
Will fix it as soon as I'm home.

@Miodec Miodec added the waiting for review Pull requests that require a review before continuing label Feb 12, 2025
@monkeytypegeorge monkeytypegeorge added backend Server stuff packages Changes in local packages labels Feb 24, 2025
@monkeytypegeorge monkeytypegeorge removed backend Server stuff packages Changes in local packages labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for review Pull requests that require a review before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants