Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix handling of background url (@fehmer) #6355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fix handling of background url (@fehmer) #6355

wants to merge 2 commits into from
+97 −3

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented Mar 9, 2025 •
edited
Loading

closes #6354

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff packages Changes in local packages labels Mar 9, 2025
@fehmer fehmer force-pushed the feature/fix-background-image branch from 4a11cb4 to a314130 Compare March 10, 2025 11:08
@fehmer fehmer force-pushed the feature/fix-background-image branch from a314130 to be5e570 Compare March 10, 2025 11:09
DimaGashko
DimaGashko reviewed Mar 10, 2025
View reviewed changes
packages/contracts/__test__/schema/config.spec.ts
},
{
name: "javascript url",
input: `javascript://alert('asdf')//https://example.com/img.jpg`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javascript schema is javascript:, not javascript://

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimaGashko DimaGashko DimaGashko left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
frontend User interface or web stuff packages Changes in local packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stored Self XSS in theme background image
3 participants
@fehmer @DimaGashko @monkeytypegeorge