First try at moving isimplicit to declaration from method. #604
Conversation
|
@genuinelucifer I am discussing about IsExplicit/IsImplicit with @tritao . In the mean time, please convert your tabs to 4 spaces and add () to D->isImplicit in Parser.cpp. The latter is not a field but a function, I am pretty sure your code does not compile at the moment. You can also start with the test. We have a special test project for checking the obtained AST, CppSharp.Generator.Tests. You can see how it works in the existing tests. |
| public void TestImplicitDeclaration() | ||
| { | ||
| Assert.AreEqual(false, AstContext.FindFunction("testExplicitFunc").Single().IsImplicit); | ||
| Assert.AreEqual(true, AstContext.FindFunction("testImplicitFunc").Single().IsImplicit); |
There was a problem hiding this comment.
The second assert is failing. Am I missing something about Implicit and Explicit declarations?
genuinelucifer
force-pushed
the
isImplicitAST
branch
from
46bc6e0 to
b09e9b5
Compare
| [Test] | ||
| public void TestImplicitDeclaration() | ||
| { | ||
| Assert.IsTrue(AstContext.FindClass("ImplicitCtor").First().Constructors.First(c => c.Parameters.Count == 0).IsImplicit); |
There was a problem hiding this comment.
Please break this line - after "First(" is a good location - and I'll merge.
genuinelucifer
force-pushed
the
isImplicitAST
branch
from
b09e9b5 to
d753c8d
Compare
First try at moving isimplicit to declaration from method.
|
@genuinelucifer thank you for your work. Let me know when you are ready for a new task. |
|
@ddobrev Pls provide me a new task to work on.
|
|
@genuinelucifer since you are more experienced now compared to 3 or 4 months ago, would you like to try the one for StringBuilder (#508) again? |
|
@ddobrev I'll definitely try that one again. I guess their will be a few
doubts in that issue. I'll try first and then ask you about those.
|
I have yet to add a test.
.
Please see if I am going in right direction or not.
Also, i was a bit confused by the 2 fields
IsImplicitandIsExplicit. I think they should be opposite of each other but they are implemented separately. Also I could not find a WalkRecord which fills the IsExplicit field.