Fix NU1510 warning as error
#415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: NuGet/NuGet.Client#6239 .NET 10 Preview 1 enables `$(RestoreEnablePackagePruning)=true` by default. This produces multiple warnings (as errors) in dotnet/android: external/debugger-libs/Mono.Debugger.Soft/Mono.Debugger.Soft.csproj : warning NU1510: PackageReference System.Runtime will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. external/debugger-libs/Mono.Debugger.Soft/Mono.Debugger.Soft.csproj : warning NU1510: PackageReference System.Reflection.Metadata will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. external/debugger-libs/Mono.Debugging/Mono.Debugging.csproj : warning NU1510: PackageReference System.Buffers will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. external/debugger-libs/Mono.Debugging/Mono.Debugging.csproj : warning NU1510: PackageReference System.Collections.Immutable will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. It appears we can safely remove these references for `net6.0` `$(TargetFramework)`.
dellis1972
approved these changes
Feb 11, 2025
thaystg
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: NuGet/NuGet.Client#6239
.NET 10 Preview 1 enables
$(RestoreEnablePackagePruning)=trueby default.This produces multiple warnings (as errors) in dotnet/android:
It appears we can safely remove these references for
net6.0$(TargetFramework), and only have them fornet472.I tested these changes here: