Added the missing 'pnpm version' to CI #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1301957 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jinmayamashita
changed the title
jinmayamashita
commented
Feb 27, 2024
.github/workflows/release.yml
Outdated
Comment on lines
21
to
22
| with: | ||
| version: latest |
There was a problem hiding this comment.
At the moment, there is no version specified.
It seems like in the future, if any specific version requirements arise, it would be best to specify them in the package.json.
|
The version is specified in the ml-frontend/.github/workflows/tests.yml Lines 15 to 18 in f2c6573 I think it would be better to either set this one to version 7, or change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
console.log())npm run test:cli)npm run test:modules)npm run e2e)Description
Resolve #1202
I've added the missing 'pnpm version' to the release CI.
Context
Resolves #(issue)
Before
The Release CI is failing
After
The Release CI has passed.
N/A
Notes