Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release script for publishing #1205

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

ptrkdan
Copy link
Collaborator

@ptrkdan ptrkdan commented Mar 4, 2024

Pull Request Checklist

  • I have checked that this pull request is not a duplicate of a pre-existing pull request
  • I have self-reviewed my changes
    • There are no spelling mistakes
    • There are no remaining debug log prints (i.e. console.log())
    • Comments were written for complex code
  • I have checked that all tests are passing (for bug fixes and enhancements)
    • CLI Test (npm run test:cli)
    • Unit Test (npm run test:modules)
    • E2E Test (npm run e2e)
  • I have added and/or modified relevant tests for my changes (for bug fixes and enhancements)
  • I have added and/or modified relevant documentations for my changes (if necessary)

Description

Context

Resolves #1202

An error occurred after trying to publish the package to npm via the release workflow. See the action logs for details.

It requires a release script in order to publish the packages to npm.

Before

The Github Action fails due to the missing release script.

After

I've added a release script in package.json which builds the packages and calls on the changeset commands (version and publish) to publish the target packages to npm.

⚠️ Breaking changes

N/A

Notes

@ptrkdan ptrkdan requested a review from jinmayamashita March 4, 2024 12:38
Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: 10962d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
start-frontend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jinmayamashita jinmayamashita enabled auto-merge March 5, 2024 15:20
Copy link
Collaborator

@jinmayamashita jinmayamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptrkdan LGTM, Thank you for your work! I'll check if this PR will automatically release to npm once merged.

@jinmayamashita jinmayamashita merged commit be495ea into main Mar 5, 2024
1 check passed
@jinmayamashita jinmayamashita deleted the fix/add-release-script branch March 5, 2024 15:23
@jinmayamashita jinmayamashita mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CI Release workflow is failing
2 participants