Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent publish private package to npm #1211

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

jinmayamashita
Copy link
Collaborator

@jinmayamashita jinmayamashita commented Mar 8, 2024

Pull Request Checklist

  • I have checked that this pull request is not a duplicate of a pre-existing pull request
  • I have self-reviewed my changes
    • There are no spelling mistakes
    • There are no remaining debug log prints (i.e. console.log())
    • Comments were written for complex code
  • I have checked that all tests are passing (for bug fixes and enhancements)
    • CLI Test (npm run test:cli)
    • Unit Test (npm run test:modules)
    • E2E Test (npm run e2e)
  • I have added and/or modified relevant tests for my changes (for bug fixes and enhancements)
  • I have added and/or modified relevant documentations for my changes (if necessary)

Description

Prevent publish private package to npm

Context

Private packages

Notes

Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: bf0e067

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
start-frontend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jinmayamashita jinmayamashita enabled auto-merge March 8, 2024 04:52
@jinmayamashita jinmayamashita requested a review from ptrkdan March 8, 2024 04:52
Copy link
Collaborator

@ptrkdan ptrkdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approving for the sake of testing. Will need to change each package to private packages later

@@ -7,5 +7,11 @@
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": []
"ignore": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEMO]
This is only a temporary fix, according the changeset's documentation. Each package should be marked private if we don't want to publish them.

@jinmayamashita jinmayamashita merged commit a10eb5b into main Mar 8, 2024
1 check passed
@jinmayamashita jinmayamashita deleted the prevent-publish-private-packages branch March 8, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants