Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make items not intended for publishing private #1218

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

jinmayamashita
Copy link
Collaborator

@jinmayamashita jinmayamashita commented Mar 21, 2024

Pull Request Checklist

  • I have checked that this pull request is not a duplicate of a pre-existing pull request
  • I have self-reviewed my changes
    • There are no spelling mistakes
    • There are no remaining debug log prints (i.e. console.log())
    • Comments were written for complex code
  • I have checked that all tests are passing (for bug fixes and enhancements)
    • CLI Test (npm run test:cli)
    • Unit Test (npm run test:modules)
    • E2E Test (npm run e2e)
  • I have added and/or modified relevant tests for my changes (for bug fixes and enhancements)
  • I have added and/or modified relevant documentations for my changes (if necessary)

Description

Context

Resolves #1202

Before

https://github.com/monstar-lab-oss/ml-frontend/actions/runs/8198926342/job/22423227560

After

The CI has succeeded.

⚠️ Breaking changes

Notes

Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: 772748d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
start-frontend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jinmayamashita jinmayamashita changed the title to private pkg Make items not intended for publishing private Mar 21, 2024
@jinmayamashita
Copy link
Collaborator Author

jinmayamashita commented Mar 21, 2024

FYI @ptrkdan There is no impact on the existing application.
We'll merge temporarily to assess the situation regarding the failed CI.

@jinmayamashita jinmayamashita disabled auto-merge March 21, 2024 02:52
@jinmayamashita jinmayamashita merged commit 28aa441 into main Mar 21, 2024
1 check passed
@jinmayamashita jinmayamashita deleted the chore/private-pkgs branch March 21, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CI Release workflow is failing
1 participant