Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoloader to verify_phpunit_xml #301

Merged
merged 2 commits into from
May 29, 2024

Conversation

andrewnicols
Copy link
Contributor

Tested locally.
I'm not sure how I can add a test for this in bats because it's only broken by a change in core which requires an autoloaded class in lib/outputcomponents.php. We could switch from 3.11 to main for testing?

@andrewnicols andrewnicols requested a review from stronk7 May 29, 2024 03:23
@andrewnicols andrewnicols self-assigned this May 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.10%. Comparing base (6fdb266) to head (e13ce66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   32.84%   26.10%   -6.75%     
==========================================
  Files          71       71              
  Lines        3203     3203              
==========================================
- Hits         1052      836     -216     
- Misses       2151     2367     +216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7
Copy link
Member

stronk7 commented May 29, 2024

Thanks Andrew, this is exactly what I was thinking about. Will look to add/modify the test soon. I think it’s easy to add one in this case pointing to main (no matter that the problem is still only @ integration.git).

@stronk7
Copy link
Member

stronk7 commented May 29, 2024

Hi,

I've added an extra commit to your branch that ensures that the tool continues working with main (while still we also keep old branches tested). Note that it's useless right now (because moodle.git doesn't have the new, breaking, code yet), but it will be useful after rolling.

This has +1, feel free to merge it if you agree.

Ciao :-)

@stronk7
Copy link
Member

stronk7 commented May 29, 2024

Merging this on @andrewnicols 's behalf :-) (and because I need this landed to provide another, hopefully interesting, PR.

@stronk7 stronk7 merged commit 8030916 into moodlehq:main May 29, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants