Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve test speed #1585

Merged
merged 1 commit into from
Feb 5, 2025
Merged

refactor: improve test speed #1585

merged 1 commit into from
Feb 5, 2025

Conversation

peter-jerry-ye
Copy link
Collaborator

Use LCG instead of chacha8

Use from_array instead of from_iter

This should make the test time half as before

@peter-jerry-ye peter-jerry-ye force-pushed the zihang/improve-test-time branch from 68e5f73 to 977fbd8 Compare January 27, 2025 08:25
@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 5160

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 85.865%

Files with Coverage Reduction New Missed Lines %
bytes/bytes.mbt 1 91.67%
Totals Coverage Status
Change from base Build 5159: 0.0%
Covered Lines: 5279
Relevant Lines: 6148

💛 - Coveralls

@peter-jerry-ye peter-jerry-ye force-pushed the zihang/improve-test-time branch from 977fbd8 to 1e5a173 Compare January 27, 2025 08:26
@peter-jerry-ye peter-jerry-ye force-pushed the zihang/improve-test-time branch from 1e5a173 to 035fad0 Compare February 5, 2025 01:49
@peter-jerry-ye peter-jerry-ye marked this pull request as ready for review February 5, 2025 01:49
@peter-jerry-ye peter-jerry-ye force-pushed the zihang/improve-test-time branch from 035fad0 to f55cc6f Compare February 5, 2025 01:50
- Use LCG instead of chacha8
- Use from_array instead of from_iter
@bobzhang bobzhang force-pushed the zihang/improve-test-time branch from f55cc6f to e754774 Compare February 5, 2025 04:30
@bobzhang bobzhang enabled auto-merge (rebase) February 5, 2025 04:32
@bobzhang bobzhang merged commit 44c3412 into main Feb 5, 2025
16 checks passed
@bobzhang bobzhang deleted the zihang/improve-test-time branch February 5, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants