Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to_string method for StringView #1609

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

Yu-zh
Copy link
Collaborator

@Yu-zh Yu-zh commented Feb 7, 2025

This method will override the default trait implementation for to_string, which adds quotation marks to the result string and is not what we would like.

@Yu-zh Yu-zh requested a review from bobzhang February 7, 2025 10:25
@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 5228

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 85.791%

Files with Coverage Reduction New Missed Lines %
string/view.mbt 1 81.03%
Totals Coverage Status
Change from base Build 5225: -0.01%
Covered Lines: 5440
Relevant Lines: 6341

💛 - Coveralls

@bobzhang bobzhang force-pushed the stringview-to-string branch from d3c8117 to e288bb2 Compare February 7, 2025 14:54
@bobzhang
Copy link
Contributor

bobzhang commented Feb 7, 2025

386966d
cc @Yu-zh override Show::to_string instead

@bobzhang bobzhang enabled auto-merge (rebase) February 7, 2025 15:04
@bobzhang bobzhang merged commit 3370468 into moonbitlang:main Feb 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants