Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate StringView and ArrayView to @string.View and @array.View #1613

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

Yu-zh
Copy link
Collaborator

@Yu-zh Yu-zh commented Feb 8, 2025

This PR is a replication #1576 without changes to BytesView. Instead, it only adds a typealias @bytes.View so that we can update the compiler to the new namings.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5234

Details

  • 39 of 41 (95.12%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
array/view.mbt 34 36 94.44%
Totals Coverage Status
Change from base Build 5232: 0.1%
Covered Lines: 5450
Relevant Lines: 6343

💛 - Coveralls

@bobzhang bobzhang merged commit 7d0e309 into moonbitlang:main Feb 9, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants