go/lint: move gofmt into golangci-lint and add ONLY_GOLANGCI flag#325
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the linting script to replace the manual gofmt check with the golangci-lint implementation and introduces an ONLY_GOLANGCI flag to skip auxiliary checks like gitleaks, govulncheck, and dependency verification. A review comment suggests also clearing the EXPERIMENTAL variable when ONLY_GOLANGCI is enabled to ensure experimental linters are correctly bypassed.
…change any behavior
adamdecaf
approved these changes
Apr 6, 2026
Member
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Author
|
Tested in a couple repos - all seems good. |
adamdecaf
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gofmtcheck and addsgofmt(withsimplify: true) as a linter withingolangci-lintONLY_GOLANGCI=yesflag to skip all other checks (dependency validation, retracted modules, build, tests) and run onlygolangci-lintTest plan
ONLY_GOLANGCI=yes bash lint-project.shand verify only golangci-lint runsbash lint-project.shnormally and verify gofmt formatting is still checked via golangci-lint🤖 Generated with Claude Code