Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set license for nuget through PackageLicenseExpression #1095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ax-meyer
Copy link

What does this PR do?

Switches from using the license file to indicate the license in the nuget package to using PackageLicenseExpression to explicitly define the license for the nugets.

Why is it important?

This allows

How to test this PR

Manual test:

  • Run nuget pack for any project in the repo
  • Start manual upload process for a nuget here: https://www.nuget.org/packages/manage/upload
  • The page will show the package metadata with license information for verification before finishing the upload

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (9f6dc48) to head (a7f2631).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         113      113           
  Lines        3448     3448           
  Branches      971      971           
=======================================
  Hits         3217     3217           
  Misses        215      215           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant