Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reflect-metadata peer #112

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Remove reflect-metadata peer #112

merged 2 commits into from
Feb 3, 2025

Conversation

Davidhanson90
Copy link
Contributor

No description provided.

@Davidhanson90 Davidhanson90 requested a review from a team as a code owner January 27, 2025 14:09
@Roaders
Copy link
Member

Roaders commented Jan 27, 2025

You still need reflect-metadata if you rely on the decorators don't you? Aren't we adding this to the docs anywhere? You could have it as an optionaPeer so that it doesn't have to be installed but if it is we can specify what version we're happy with.

@Davidhanson90
Copy link
Contributor Author

You still need reflect-metadata if you rely on the decorators don't you? Aren't we adding this to the docs anywhere? You could have it as an optionaPeer so that it doesn't have to be installed but if it is we can specify what version we're happy with.

its in the docs already

@Davidhanson90 Davidhanson90 merged commit e22f31f into morganstanley:main Feb 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingenito bingenito bingenito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Davidhanson90 @Roaders @bingenito