Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/streamline testplan report #1163

Merged
merged 22 commits into from
Mar 17, 2025

Conversation

zhenyu-ms
Copy link
Contributor

@zhenyu-ms zhenyu-ms commented Dec 24, 2024

Bug / Requirement Description

reduce the size of generated report files

Solution description

  • remove unused report entry attributes
    • fix_spec_path
    • status_override, status_reason if empty (what's their use case?)
    • depending on report cat, env_status, part, strict_order & host
    • depending on --code enabled, line_no, code_context & file_path
  • remove unused assertion entry attributes
    • merge utc_time & machine_time into timestamp (in unix format) and store tz info in nearest test-level report under key timezone
    • omit DEFAULT category & flag
  • introduce date-fns/tz, upgrade date-fns accordingly
  • omit fixed tablelog indices in exported json
  • avoid match status expansion for dict/fix match entries
  • delta encode level info of all dict/fix entries in exported json
  • update certain frontend compo tests w testing-library/react

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@zhenyu-ms zhenyu-ms marked this pull request as ready for review January 2, 2025 09:46
@zhenyu-ms zhenyu-ms requested a review from a team as a code owner January 2, 2025 09:46
Pyifan
Pyifan previously approved these changes Feb 18, 2025
- delta encode level info of all dict/fix entries
- avoid match status expansion for dict/fix match entries
- omit fixed indices of tablelog entry
- update certain frontend compo test w @testing-library/react
@zhenyu-ms zhenyu-ms changed the title Refactor/streamline testplan report - part 1 Refactor/streamline testplan report Mar 4, 2025
@zhenyu-ms zhenyu-ms force-pushed the streamline-report branch 2 times, most recently from 7119808 to 2408d5e Compare March 7, 2025 06:14
- add timezone field to TestReport
- have default values to timezone fields
- update tpsreport test data
- fix timer field handling in both frontend & driver-info assertions
- update newsfrag
@zhenyu-ms zhenyu-ms force-pushed the streamline-report branch from 2408d5e to f9098e3 Compare March 7, 2025 07:58
@Pyifan
Copy link
Contributor

Pyifan commented Mar 13, 2025

Need to add "host" back as it is used by resource monitor, and please run internal tests before merging. Otherwise looks good to me, and really appreciate the effort you put into this refactoring!

Pyifan
Pyifan previously approved these changes Mar 14, 2025
@zhenyu-ms zhenyu-ms merged commit f5e883c into morganstanley:main Mar 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants