Repository navigation
ci: compile the pbr.user.*.uc scripts against ucode master - #200
Merged
Merged
Conversation
ucode fe9e2947 (2026-09-04, now in OpenWrt main as ucode d2e8b8d) turns adjacent template literals into a syntax error, so newer ucode no longer accepts everything older ucode accepts. owut broke on exactly this and was fixed in efahl/owut 9fd6be9f22. The lint step in openwrt-release.yml already compiles the modules and cli.uc against ucode master on every push and PR, but not the user scripts in files/usr/share/pbr/, and no test loads them. Add them via a glob so new user scripts are covered too. Also correct the "newer ucode accepts everything older accepts" comments in ucode-syntax.yml and check-ucode-syntax.sh, and point to the lint step for the other direction. Tested with a host build of ucode d2e8b8d: all 12 files pass; with an adjacent pair appended to pbr.user.aws.uc the step fails with "Adjacent template literals are not implicitly concatenated". Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ucode
fe9e2947(2026-09-04, jow-/ucode#433) turns adjacent template literals into a syntax error:OpenWrt main picked this up on 2026-10-19 (ucode
d2e8b8d, openwrta4e922953c); 25.12 still runs85922056and is not affected. owut broke on it and was fixed in efahl/owut@9fd6be9f22. So newer ucode no longer accepts everything older ucode accepts.pbr is clean today. Checked with a host build of
d2e8b8d: all 17 tracked.ucfiles compile,luci.pbrcompiles, andtests/run_tests.shpasses 75/75.The gap this closes. The "Lint ucode modules" step in
openwrt-release.ymlalready compiles the 9 modules andcli.ucagainst ucode master on every push and PR. That catches this kind of break in those files. It did not compile the user scripts infiles/usr/share/pbr/(pbr.user.aws.uc,pbr.user.netflix.uc), and no test loads them. This PR adds them through a glob, so future user scripts are covered too.It also corrects the "newer ucode accepts everything older accepts" comments in
ucode-syntax.ymlandtests/check-ucode-syntax.sh. Both now point to the lint step for the other direction.Tested by running the edited step locally with ucode
d2e8b8d:ok, exit 0;pbr.user.aws.uc: the step fails with the error above, exit 1.Not changed: the module lines'
-cdynlink=fs,uci,ubusprintsUnrecognized -c flag "uci"/"ubus". ucode takes one module perdynlink=, so onlyfsis applied. It is harmless noise and predates this PR.