Repository navigation
pbr-1.2.4: make the IPv4 validation test check is_ipv4() - #208
Merged
Merged
Conversation
The test built a table of cases and looped over it without calling anything, then printed the package name and version. It passed with is_ipv4() hard-wired to true and hard-wired to false. Its comments said is_ipv4() is not exported, which stopped being true when the validators moved to their own module. Call is_ipv4() through create_validators(), as the domain test does, and fail on any difference. The 17 original cases stay, with boundaries added for every branch of the pattern in both octet groups, and for the prefix length. filter_options() is covered too, as that is how pbr sorts a policy's addresses by family. Reported by the review of openwrt/packages#31156. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Erik Conijn <egc112@msn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test built a table of cases and looped over it without calling anything, then printed the package name and version. It passed with is_ipv4() hard-wired to true and hard-wired to false. Its comments said is_ipv4() is not exported, which stopped being true when the validators moved to their own module.
Call is_ipv4() through create_validators(), as the domain test does, and fail on any difference. The 17 original cases stay, with boundaries added for every branch of the pattern in both octet groups, and for the prefix length. filter_options() is covered too, as that is how pbr sorts a policy's addresses by family.
Reported by the review of openwrt/packages#31156.
Assisted-by: Claude:claude-opus-5-5