Drop support for Qt 5.13 #451
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHendricks
added
the
v2.1
MHendricks
force-pushed
the
mikeh/2.1_drop_qt5.13
branch
3 times, most recently
from
435c4e9 to
dbb432a
Compare
MHendricks
force-pushed
the
mikeh/2.1_drop_qt5.13
branch
from
dbb432a to
9542ea1
Compare
MHendricks
force-pushed
the
mikeh/2.1_drop_qt5.13
branch
2 times, most recently
from
fffb1d8 to
71354a8
Compare
MHendricks
force-pushed
the
mikeh/2.1_drop_qt5.13
branch
2 times, most recently
from
ddbedc6 to
cee1eea
Compare
Excluding required python 2 specific fixes
Leaving Python 3 only fixes for now
Prevent json parsing errors caused by printing when printing json
Cy2020 uses python 3.7 and Qt 5.13. Correct Cy2021 test to use python 3.7 Improve py 3.7 PyQt5-sip workaround in tox. This prevents needing to have visual studio installed to compile sdist by forcing it to use versions providing pre-built wheels.
On linux these require the pulse audio libraries.
Sorts PySide before PyQt and Qt 6 before Qt 5. Also Remove QIntList from membership report. It will not be common for the 2.0 versions of Qt.py because it is not available in PySide2, PyQt5 or PyQt6. It's also adding a lot of visual clutter being present in ~50 modules in PySide6.
Uses the common_members.json generated list Update membership.py to exclude platform specific members
This includes a workaround for python 3.7 and PySide2 in python 3.9.
Update github actions for artifact upload/download
This enables mapping QAction to the QtGui for the PySide6 reference, but still add it to QtWidgets for backwards compatibility.
Adds support for adding `Qt.QtOpenGl` and other modules. These modules don't actually have any common members because the different bindings used unique module names. For example in Qt6 all QtOpenGL functions are stored under QtOpenGL, but in PySide2 they are stored under QtGui and QtOpenGLFunctions, and PyQt5 is ... complex. Also moves most of the extras passed to _setup into the `__extras__` key of `_misplaced_members[binding]`. This allows QtSiteConfig to customize them. Remove Qt 5.11 legacy support for PyQt5 sip import. QtWidgets.QFileSystemModel is now mapped to all misplaced bindings and tested.
This shows how to use QtSiteConfig to add this module as well as modifying the new `__extras__` misplaced member feature.
This adds several common members that had to be excluded when supporting Qt 5.13.
MHendricks
force-pushed
the
mikeh/2.1_drop_qt5.13
branch
from
cee1eea to
5f803f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first of potentially several pull requests to update Qt.py, dropping support for Qt 5.13. The new minimum version of Qt is 5.15 adding support for more modules. This will be released under the 2.1 version of Qt.py to allow us to release patches for the previous Qt 5.13 versions if required.
NOTE: This will be rebased and merged on top of #450. See roadmap for the plan.