-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI config #83
Update CI config #83
Conversation
JStech
commented
May 4, 2021
•
edited by rhaschke
Loading
edited by rhaschke
- Use industrial_ci UNDERLAY again, after learning that we did Use UNDERLAY feature of industrial_ci #76 wrong.
- Unify config with the one from main MoveIt repo
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 72.75% 79.16% +6.42%
==========================================
Files 10 9 -1
Lines 554 499 -55
==========================================
- Hits 403 395 -8
+ Misses 151 104 -47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the chance to unify the CI config with that of the MoveIt main repo.
I also added a Noetic build. However, this fails. Please have a look!
|
||
name: CI | ||
|
||
on: [push, pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating this, do we want to add the pre-release test here too?
That test failure is because OpenCV 3.2, the default version for Ubuntu 18.04, has a buggy ArUco board pose detector. See discussion here, #5. I added a check to use the incorrect pose for 3.2 and the correct pose otherwise. |
moveit_calibration_plugins/handeye_calibration_target/test/handeye_target_aruco_test.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view, this is ready to merge.
I'm not sure though, that we should consider wrong results for the unit tests against OpenCV 3.2. Alternatively, we could skip the test completely (in this case). However, then the remaining code isn't tested as well. Hence, I'm fine with the current solution as well.