Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between collision and bound error in JointInterpolationPlanner #529

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Feb 7, 2024

☝️ Small PR to make the errors more informative.

@sjahr sjahr requested a review from Abishalini February 7, 2024 09:50
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5a2607e) 42.47% compared to head (dac8545) 42.47%.
Report is 1 commits behind head on ros2.

Files Patch % Lines
core/src/solvers/joint_interpolation.cpp 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             ros2     #529      +/-   ##
==========================================
+ Coverage   42.47%   42.47%   +0.01%     
==========================================
  Files          83       83              
  Lines        8080     8086       +6     
==========================================
+ Hits         3431     3434       +3     
- Misses       4649     4652       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v4hn v4hn merged commit 4de8d23 into moveit:ros2 Feb 7, 2024
5 checks passed
rhaschke pushed a commit to ubi-agni/moveit_task_constructor that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants