Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputeIK: report failures the modern way #651

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Feb 2, 2025

Don't use command-line warnings, but spawn failure solutions. This fixes #650 (comment):

Failing stage(s):
compute ik (0/4): ik frame unknown in robot: 'foo'

Additionally, to correctly report ComputeIK's failure comments, I had to adapt explainFailure().

Don't use command-line warnings, but spawn failure solutions.
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 21.27660% with 37 lines in your changes missing coverage. Please review.

Project coverage is 58.97%. Comparing base (8318546) to head (acb31e2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
core/src/stages/compute_ik.cpp 0.00% 12 Missing ⚠️
core/src/stages/current_state.cpp 0.00% 7 Missing ⚠️
core/src/stages/fixed_cartesian_poses.cpp 0.00% 6 Missing ⚠️
core/src/stages/generate_pose.cpp 0.00% 6 Missing ⚠️
core/src/stages/generate_random_pose.cpp 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   59.21%   58.97%   -0.24%     
==========================================
  Files          97       97              
  Lines        8976     9001      +25     
==========================================
- Hits         5314     5307       -7     
- Misses       3662     3694      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaniGarciaLopez
Copy link
Contributor

Thanks for this improvement @rhaschke! There is one missing check in generate_pose.cpp here, otherwise LGTM.

@rhaschke rhaschke merged commit 9ea1692 into moveit:master Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComputeIK fails when any collision objects are in the scene.
3 participants