Fixes for transient variables in JANI #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building JANI models with rewards, we employ an optimization that lifts similar transient edge destination assignments to the edge, so that they only have to be evaluated once for a given edge (and not for each destination). This previously would yield incorrect rewards when the initial (default) value of a transient variable is not zero. We make the decision when to apply the optimization more conservative to avoid such cases. Also fixes a minor issue in a sanity check
|
LGTM. Thanks for fixing it so quickly. Also incorporates the fix from #665. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building JANI models with rewards, we employ an optimization that lifts similar transient edge destination assignments to the edge, so that they only have to be evaluated once for a given edge (and not for each destination). This previously would yield incorrect rewards when the initial (default) value of a transient variable is not zero.
We make the decision when to apply the optimization more conservative to avoid such cases.
Also fixes a minor issue in a sanity check.