Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract new strings (2025-02-19) #263

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Extract new strings (2025-02-19) #263

merged 2 commits into from
Feb 20, 2025

Conversation

mozilla-pontoon
Copy link
Collaborator

Automated changes by create-pull-request GitHub action

@mozilla-pontoon mozilla-pontoon requested a review from a team as a code owner February 11, 2025 15:05
Copy link
Contributor

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #264 to add exceptions to linter.
I still have to look into this recurring comment as I do not see it as part of the strings:
"The '
' symbols denote empty lines separating the first link parameter from the rest of the text."
Once the strings are exposed, I will then share the sticker screenshots with localizers.

@mozilla-pontoon mozilla-pontoon changed the title Extract new strings (2025-02-11) Extract new strings (2025-02-18) Feb 18, 2025
@mozilla-pontoon mozilla-pontoon changed the title Extract new strings (2025-02-18) Extract new strings (2025-02-19) Feb 19, 2025
<note>The accessibility label read when loading a document in the web view's custom document loading UI.</note>
</trans-unit>
<trans-unit id="WebView.DocumentLoadingLabel.v137" xml:space="preserve">
<source>Loading ...</source>
Copy link
Contributor

@Delphine Delphine Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ih-codes: Could you please update this string to remove the space before the three dots - as well as create an ellipsis too (vs three dots)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to temporarily remove this string so we are unblocked.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up, fix is in PR here: mozilla-mobile/firefox-ios#24858

@flodolo flodolo merged commit fc00ff6 into main Feb 20, 2025
2 checks passed
@flodolo flodolo deleted the l10n_automation branch February 20, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants