-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract new strings (2025-02-19) #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened #264 to add exceptions to linter.
I still have to look into this recurring comment as I do not see it as part of the strings:
"The '
' symbols denote empty lines separating the first link parameter from the rest of the text."
Once the strings are exposed, I will then share the sticker screenshots with localizers.
74ab469
to
9e46339
Compare
9e46339
to
7aadef4
Compare
templates/firefox-ios.xliff
Outdated
<note>The accessibility label read when loading a document in the web view's custom document loading UI.</note> | ||
</trans-unit> | ||
<trans-unit id="WebView.DocumentLoadingLabel.v137" xml:space="preserve"> | ||
<source>Loading ...</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ih-codes: Could you please update this string to remove the space before the three dots - as well as create an ellipsis too (vs three dots)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to temporarily remove this string so we are unblocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up, fix is in PR here: mozilla-mobile/firefox-ios#24858
Automated changes by create-pull-request GitHub action