Skip to content

Commit

Permalink
Address some review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
oskirby committed Aug 26, 2024
1 parent 0e6fa20 commit 305dbef
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/flatpak.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Generate Appstream metainfo
shell: bash
working-directory: src/linux/flatpak
run: ./appstream-metainfo.sh > org.mozilla.vpn.metainfo.xml
run: ./appstream-metainfo.sh | tee org.mozilla.vpn.metainfo.xml

- name: Update git reference
shell: bash
Expand Down
6 changes: 3 additions & 3 deletions linux/flatpak/appstream-releases.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

GITHUB_TOKEN = os.environ.get('GITHUB_TOKEN')

class release_info:
class ReleaseInfo:
def __init__(self, owner, project, tag):
headers = {
'Accept': 'application/vnd.github+json',
Expand Down Expand Up @@ -56,7 +56,7 @@ def __str__(self):
return f"{self.tag}"

def __repr__(self):
return f"release_info({self.owner}, {self.project}, {self.tag})"
return f"ReleaseInfo({self.owner}, {self.project}, {self.tag})"

@property
def date(self):
Expand Down Expand Up @@ -105,7 +105,7 @@ def fetch_releases(gitremote, limit=8):
tags.sort(key=Version, reverse=True)

# Fetch the release data
return [release_info(user, project, tag) for tag in tags[:limit]]
return [ReleaseInfo(user, project, tag) for tag in tags[:limit]]

if __name__ == "__main__":
## Parse arguments to locate the input files and options.
Expand Down
4 changes: 2 additions & 2 deletions linux/flatpak/flatpak-embed-crates.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ case $1 in
gunzip -c $1 > $TMPDIR/archive.tar
;;
*)
echo "Unsupported archive: $1" >&2
echo "Unsupported archive format: $1" >&2
exit 1
;;
esac
Expand All @@ -39,7 +39,7 @@ case $1 in
gzip -c $TMPDIR/archive.tar > $1
;;
*)
echo "Unsupported arachive: $1" >&2
echo "Unsupported archive format: $1" >&2
exit 1
;;
esac

0 comments on commit 305dbef

Please sign in to comment.