Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Update asn1-rs crate and friends #10255

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Nit: Update asn1-rs crate and friends #10255

merged 2 commits into from
Feb 4, 2025

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Feb 3, 2025

Description

It looks like we have a bit of a dependency tangle that dependabot isn't able to resolve. In particular it seems like the asn1-rs, oid-registry and x509-parser crates all need to be updated together to cross some kind of API change. So, let's update these dependencies manually so that we can group them together into the same PR.

Reference

Conflicting dependabot PRs:

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby marked this pull request as ready for review February 3, 2025 21:41
@oskirby oskirby requested review from strseb and mcleinman February 3, 2025 22:55
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@oskirby oskirby merged commit ad7d805 into main Feb 4, 2025
117 checks passed
@oskirby oskirby deleted the cargo-asn1-rs-update branch February 4, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants