Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: clean database and case 0 bugs #47

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

isabelrios
Copy link
Collaborator

There are two issues identified:
In order to list the current bugs to be verified, we need to clean the table first.
In Android due to the low number of qe-verify+, it could be the case that there are no bugs to verify. This is considered now.

@isabelrios
Copy link
Collaborator Author

I have tested the changes in Staging first to be sure they work.

@isabelrios isabelrios requested a review from rpappalax October 23, 2024 09:59
Copy link
Collaborator

@rpappalax rpappalax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly asking questions for my own edification

df['modification_date'] = pd.to_datetime(df['modification_date'], format='%Y%m%dT%H:%M:%S') # noqa
df['creation_date'] = pd.to_datetime(df['creation_date'], format='%Y%m%dT%H:%M:%S') # noqa
if not rows:
print("There are no bugs to verify today")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is diagnostic for the github action logs 👍🏼

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to know why did not have data if that's the case and not due to any other error / situation ..

@@ -146,6 +152,13 @@ def __init__(self):
super().__init__()
self.db = Database()

def qa_needed_delete(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I remember correctly, this is be cause we're using the DB as temp cache for this data so wiping it before rehydrating it is the way to go. true?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the case for TestRail test suites. In this case I want to clean the table so that it shows daily the active bugs that require qa attention

qe_needed_count = self.db.report_bugzilla_qa_needed_count(data_frame)
self.db.report_bugzilla_qa_needed_count_insert(qe_needed_count)
# Drop the columns 'type_id' and 'id'
df_cleaned = df.drop(columns=["type_id", "id"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, are you trimming these columns from just the dataframe because ... not needed / housekeeping?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, those are not needed, those are the id for the flag and its type which do not give much information

@isabelrios isabelrios merged commit ccf8b8a into master Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants